-
Notifications
You must be signed in to change notification settings - Fork 8
Run TPIP workflow in PRs for main
#60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Thanks! Just compared to other workflows. Removing |
It won't be able to commit the report into the PR branch if relying on the default SHA (which typically is a merge of pr head and base branches. |
Thanks! Should have listened. It indeed can't operate on the default. |
JonatanAntoni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now, its looking good and seems to work as expected.
I.e., the TPIP.md got updated.
|
Yes, it only updated the timestamp. Let's see how this behave on branches without TPIP updates. |
|
Having written that, something seems to confuse now the other workflows. Presumably the TPIP commit while the other workflows were running. Need to have another look in the afternoon. |
|
After discussing again with Jonatan, I looks like this is a limitation we have to live with for now. We can review after Embedded World how to further smoothen this process. The only downside is that we worst case have to fiddle around with PRs that change dependencies. |
Fixes
N/A
Changes
main. This shall work around the CI user not having (and not supposed to have) direct write access tomain.Screenshots
Checklist